Merge setup.cfg into pyproject.toml and use dependency groups (#316)#318
Merge setup.cfg into pyproject.toml and use dependency groups (#316)#318jaideepkathiresan wants to merge 3 commits intomatplotlib:mainfrom
Conversation
samcunliffe
added
New feature
samcunliffe
left a comment
samcunliffe
left a comment
There was a problem hiding this comment.
Thanks a lot for your first contribution, @jaideepkathiresan! 👋
I'm pretty confident we need to tweak the tox.ini to get tox to run the correct thing (dependency groups), then remove the old style [project.optional-dependencies].
Thanks for the work so far, sorry for the slight scope-drift. It's a bit of a bigger task than I first thought. Absolutely no worries if you don't have the capacity for this, just let us know and one of us will pick it up!
|
Hi @samcunliffe, thanks you so much for the feedback! Yeah, I guess for the current scope, you could assign someone else, I am also kind of occupied with something. |
Also adding tox-uv to dev group.
There was a problem hiding this comment.
As written, this solves the ticket. And I've pushed some commits to @jaideepkathiresan's branch so I probably shouldn't approve myself.
Follow up thoughts:
- We might want to merge
tox.iniintopyproject.tomland also usetox-uvin the workflow (it's not too bad: rough proof of concept). - We might want to drop
toxentirely from our tools. - We might want to switch to
uvin the actions workflows and elsewhere.
|
Hey @dstansby, this OK with you? |
2 participants
This PR addresses Issue #316
Summary of Changes
setup.cfgintopyproject.tomlsetup.cfg